Implement fastboot continue when omitting boot img from cdba command line #66
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xB0D
commented
Jan 1, 2024
|
@0xB0D just for the reference, meta-qcom's |
|
BTW, does this work with |
|
@lumag I tested it as either/or - either continue or the existing flow - however once you've continued once, you can subsequently repeat if the flag is set 8bf824b#diff-e2595c859cae197be14afcd161104e8383205cf6b64952b13114f0e6126f498fR552 |
|
@0xB0D Ack. |
lumag
approved these changes
Jan 15, 2024
|
@0xB0D "The base branch requires all commits to be signed." :-( |
|
@lumag sure I'll repost |
Add cdba-server side support for "fastboot continue" which allows fastboot to continue its default boot process. I find it useful to setup my boards with an additional SD card which I frequently use the default image on eMMC to chroot to and populate modules, rebooting into fastboot and subsequently booting via fastboot a rootfs on the SD card. Signed-off-by: Bryan O'Donoghue <[email protected]>
Add the ability to omit the image from the cdba call. In this case default to "fastboot continue" on the cdba-server side. Regular booting continues to work like this: cdba -b db410c -h benchtop-cdba ./qlt-kernel/build/square_5.x-tracking/boot_t2a.img New option to boot the default image a proxy for "fastboot continue" cdba -b db410c -h benchtop-cdba Signed-off-by: Bryan O'Donoghue <[email protected]>
|
@lumag signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I find handy is being able to fastboot continue.
My typical workflow is compile/edit whatever then boot the default image on the target board, populate modules on either the rootfs or on a sd card, then reboot to fastboot again.
On the subsequent reboot fastboot into the rootfs with the kernel image I've compiled.
I find this a handy way to always have a default recovery image on the board I can boot.
This series makes the boot.img non-mandatory when invoking cdba.
In this case cdba will issue a new MSG_FASTBOOT_CONTINUE command to cdba-server.
Unsurprisingly MSG_FASTBOOT_CONTINUE => "fastboot continue" on the cdba-server side.
This still works ie "fastboot download; fastboot boot"
cdba -b db410c -h benchtop-cdba ./qlt-kernel/build/square_5.x-tracking/boot_t2a.img
If you drop the boot image though the flow is "fastboot continue"
cdba -b db410c -h benchtop-cdba
My test system
devices:
qcomlt_debug_board: /dev/serial/by-id/usb-Linaro_DebugBoard_68cb7c6b75a4451502020223236460ff-if00
console: /dev/serial/by-id/usb-Linaro_DebugBoard_68cb7c6b75a4451502020223236460ff-if02
name: "db410c"
fastboot: 1dcd2e70
fastboot_set_active: true
fastboot_key_timeout: 5